(There is often negative feedback regarding UI changes, so I wanted to give some positive feedback this time.)
Topic: New source UI on upload form
Posted under General
It's almost perfect, only a couple of CSS tweaks are needed now.
/* (New Upload/Sources) Locks in place "Add another source" button by swapping it with source input, changes - to ✖ 25-09-24 */
.col2:has(.upload-source-list) {display: flex; flex-direction: column}
.upload-source-more {order: -1; margin-bottom: .25rem; .upload-source-add {border-radius: .25rem; padding: .25rem .3rem}}
.source_warning {order: 1; margin-bottom: 0}
.upload-source-row {& input {margin-right: 1px} & button {font-size: 0%; &:before {content: "✖"; font-size: 1rem; vertical-align: middle}}}
waydence said:
It's almost perfect, only a couple of CSS tweaks are needed now./* (New Upload/Sources) Locks in place "Add another source" button by swapping it with source input, changes - to ✖ 25-09-24 */ .col2:has(.upload-source-list) {display: flex; flex-direction: column} .upload-source-more {order: -1; margin-bottom: .25rem; .upload-source-add {border-radius: .25rem; padding: .25rem .3rem}} .source_warning {order: 1; margin-bottom: 0} .upload-source-row {& input {margin-right: 1px} & button {font-size: 0%; &:before {content: "✖"; font-size: 1rem; vertical-align: middle}}}
You're right, putting the button above the sources feels much more intuitive.
It always felt a bit jarring having to move the cursor down each time I wanted to add a new source. (Especially with the tiny buttons that were there previously)
snedmano said:
It always felt a bit jarring having to move the cursor down each time I wanted to add a new source.
Pressing the Enter key while your cursor is in the source input will add a new source field.
Also, if you want to copy-paste multiple sources (every source on a separate line) you can just paste the whole thing into one of the inputs and it will figure it out.
cinder said:
Pressing the Enter key while your cursor is in the source input will add a new source field.
Also, if you want to copy-paste multiple sources (every source on a separate line) you can just paste the whole thing into one of the inputs and it will figure it out.
TIL. Doesn't make adding sources any faster for me. Maybe if there was a button that extracted text from clipboard? Still, would be nice if that was mentioned somewhere on that page.
EDIT: I was wrong, it does make adding sources faster.
Updated
cinder said:
Also, if you want to copy-paste multiple sources (every source on a separate line) you can just paste the whole thing into one of the inputs and it will figure it out.
Ah, neat. (I still think putting the button above would be a good idea to stop it from moving around.)
I could swear I tried this before and it just removed all linebreaks when pasting.
Is this something that came with the recent update?
Looking at the pull request in the changelog, seems like it did.
waydence said:
Maybe if there was a button that extracted text from clipboard?
On desktop, Shift+Insert should work to copy text from clipboard. A dedicated "Copy from clipboard" button may not be a bad idea, but since you'll be doing text input for uploading anyway, that common keyboard shortcut should be fine.
watsit said:
On desktop, Shift+Insert should work to copy text from clipboard.
Shift+Insert? why bring up Shift+Insert and not Ctrl+V?
dba_afish said:
Shift+Insert? why bring up Shift+Insert and not Ctrl+V?
I've never known Shift+Insert also works for pasting. (Not sure why you would ever want to use it over Ctrl+V)
Again what learned.
dba_afish said:
Shift+Insert? why bring up Shift+Insert and not Ctrl+V?
I never think about those ones. I'm used to Ctrl+Insert for copy, Shift+Delete for cut, and Shift+Insert for paste, which work more consistently in different apps (ctrl-v doesn't work in my terminal, for example).
watsit said:
ctrl-v doesn't work in my terminal, for example
CTRL+SHIFT+V will likely work, that's a quirk of terminals because of control signals
snedmano said:
I could swear I tried this before and it just removed all linebreaks when pasting.
Is this something that came with the recent update?
Yes, I implemented it.
snedmano said:
(I still think putting the button above would be a good idea to stop it from moving around.)
Sure.
I'll put both the "no available source" and "add another source" inputs above the rest of the source fields in the next update.
waydence said:
Doesn't make adding sources any faster for me.
I was not speaking to you?
cinder said:
Sure.
I'll put both the "no available source" and "add another source" inputs above the rest of the source fields in the next update.
Neat, thanks!
cinder said:
Sure.
I'll put both the "no available source" and "add another source" inputs above the rest of the source fields in the next update.
Can you also consider adding tabindex='-1' to [-] buttons? I think it's a bit annoying that you have to double tab to switch to the next one.
In the meantime, here's a css solution:
/* (New Upload/Sources) Removes the need to double-(shift)-tab to switch between source fields 25-10-05 */
@media (min-width: 50rem) {.upload-source-row:has(input:focus, + .upload-source-row input:focus) {button {display: none}
&:after {content: ""; background: rgba(255,255,255,.5); border-radius: 0 .25rem .25rem 0; box-sizing: border-box; width: 1.5rem} } }
EDIT: added support for shift-tab.
Updated
waydence said:
Can you also consider adding tabindex='-1' to [-] buttons? I think it's a bit annoying that you have to double tab to switch to the next one.
No thank you, I will not be breaking tab navigation.
You can use arrow keys to navigate the inputs.
cinder said:
You can use arrow keys to navigate the inputs.
If I understand you correctly, the top and down arrow keys should switch the focus between the different sources.
That doesn't work for me, it just goes to the beginning / end of each source, but still stays in that line. (Basically, acting like the Pos1 & End Keys)
Personally, I don't really mind it that much, since I much prefer the copy & paste all sources method. (Thank you for implementing that btw.)
snedmano said:
If I understand you correctly, the top and down arrow keys should switch the focus between the different sources.
That doesn't work for me, it just goes to the beginning / end of each source, but still stays in that line. (Basically, acting like the Pos1 & End Keys)
Well it's obviously on the new version that's only been deployed to e926 so far.
It'll be on the main site on Wednesday, as usual.
cinder said:
Well it's obviously on the new version that's only been deployed to e926 so far.
It'll be on the main site on Wednesday, as usual.
Oh, okay. Sorry for the misunderstanding.
cinder said:
Well it's obviously on the new version that's only been deployed to e926 so far.
It'll be on the main site on Wednesday, as usual.
Checked it out, that's pretty neat. But switching to new source field on enter is even better.
Also found a possible explanation for "Add another source" button being below sources - this allowed to tab straight from URL to the first source.
I think a great fix improvement would be to have enter in URL field switch focus to the first source field.
Updated