Topic: Hotkeys while video is focused are now disabled?

I want to favorite a post while watching a video??
its worked this way forever why change it?

this shit sucks
https://github.com/e621ng/e621ng/commit/f8ab4fa279d6a871926e6d0d41cf2805898fc5bf

I was going to make a bug report before I found out it was intended

It would interfere with video playback shortcuts; when Flash content was natively supported in the browser, we had to disable keyboard shortcuts on those pages for the same reason.

The shortcuts are only disabled when the video has keyboard focus; tapping/clicking off of the video will make the video lose focus, re-enabling shortcuts. You can manually removing focus from the player when you play a video & they'll work just fine.

I appreciate the effort being put into making the hotkeys menu better, I think they're good. And I like the new interface changes.
but I don't like this change.
I think the change adds jank. I would argue that its not expected for a video element to be blocking hotkeys.

I understand that we want to leave the browser's default media controls alone. And I don't want you to 'undo' the other recent additions to the hotkey menu, but there is got to be a better way to permit the spacebar / arrow keys to be rebindable.

giffyz said:
I would argue that its not expected for a video element to be blocking hotkeys.

We explicitly had complaints about the e6 hotkeys overriding the native video player keyboard shortcuts.
And I agree with those complaints somewhat – the site should not break browser functionality.

We had been looking into our options here. But I'm not sure how much we can really do.
One option we discussed was to add hotkeys to focus on and off the video. But that seems like a half-measure, since it's just as easy to simply click off the focused video to re-enable the hotkeys.

Another option is to remove the default bindings for left and right arrow. Those seem to be the only hotkeys that intersect with the vanilla ones.
But I am 100% certain that this will cause hundreds of people to complain.

Only the intersecting keys could be blocked from their e621 action while focusing a video so that non-intersecting hotkeys can still be used.
This seems like a feasible compromise to me, but you'd know better than I what people complain about.

For example instead of returning early if activeElement is input or textarea or video it could be something like this:

let the video interference keys be the spacebar and arrow keys
...
return early if activeElement is input or textarea
return early if activeElement is video AND key is in video interference keys